Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #2

Open
fmeringdal opened this issue May 31, 2021 · 4 comments
Open

Logging #2

fmeringdal opened this issue May 31, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fmeringdal
Copy link
Owner

Currently all logging is done with console.log which is not good. It should be replaced with a logging library.

@fmeringdal fmeringdal added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 31, 2021
@sha-yon
Copy link

sha-yon commented Jul 17, 2021

Hi @fmeringdal, would like to take this one up. Can we discuss?

@fmeringdal
Copy link
Owner Author

Sure @sayan2306 👍

@yugeeklab
Copy link
Contributor

I would like to address this issue using "debug"

"debug" : https://github.com/visionmedia/debug

debug is a tiny debugging tool which can use in both server and frontend side.

Can I try to solve this issue?

@fmeringdal
Copy link
Owner Author

Hi @YuTaeseong !

I dont think debug library is what is needed here. The debug library is as the name implies for debugging during development. Look at this comment from one of the debug maintainers.

What I would like to see is some logging library with support for different log levels (info, error, warn, debug etc) and structured logging (more context on each log message, like timestamp, server id etc) which can be indexed into a search engine like elasticsearch.
Two libraries that might have support for this is pino and winston if you would like to have a look at them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants