This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix zeroFields setting when merging slices into maps #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 72.10% 72.10%
=======================================
Files 57 57
Lines 1975 1975
=======================================
Hits 1424 1424
Misses 412 412
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
katrogan
previously approved these changes
May 4, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
approved these changes
May 4, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Fix zeroFields setting when merging slices into maps Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Feedback Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
TL;DR
viper, by design, doesn't support case sensitive keys and that ends up lower casing all keys regardless of whether the target field is a map. Flyte config has been using a workaround where we set the config values (e.g. in yaml files) for maps as yaml arrays instead to preserve their case sensitivity. After this change that sets ZeroFields to true, the logic in mapstructure package breaks when doing the slice to map conversion. This PR adds an additional hook that does the conversion.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#948