This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Zero fields overriden in config files to avoid undesired merging logic #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 72.10% 71.74% -0.36%
==========================================
Files 57 57
Lines 1975 1975
==========================================
- Hits 1424 1417 -7
- Misses 412 418 +6
- Partials 139 140 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
#81) Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
TL;DR
The default behavior for the mapstructure package used to merge new and default configs is to merge maps by setting all keys and to merge arrays by replacing the first n elements with the new n elements while leaving the rest intact.
The intuitive behavior, talking to users, is that when a field is set in a config, it completely replaces the default config.
Type
Are all requirements met?
Complete description
There is a ZeroFields setting to be set in the decoder used. It only zeros fields that are being replaced from the config file and not just all fields...
Tracking Issue
flyteorg/flyte#948