migrate to go module #50
Conversation
honnix
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
|
Some tests are failing? But this looks awesome. |
|
This and flyteidl don't work and there was weird issue that I haven't solved. |
|
golang/go@f851253 might be related. |
|
I believe the problem is here https://github.com/lyft/flytestdlib/blob/master/cli/pflags/api/generator.go#L304 This doesn't support module. I'm looking into using |
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 71.95% 71.96% +0.01%
==========================================
Files 56 56
Lines 2232 2240 +8
==========================================
+ Hits 1606 1612 +6
- Misses 503 504 +1
- Partials 123 124 +1
Continue to review full report at Codecov.
|
|
Well it works! |
|
@EngHabu PTAL again. We will need to release a new version of |
|
Another thing to mention is, some test cases won't pass on Mac due to "too many opened files" in some temp folder. |
|
Awesome!! Love it! Thank you for investigating and fixing the goimports issue |
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
* migrate to go module * tidy * do not force * try packages * extract into a method
No description provided.