This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
migrate to go module #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might relate to golang/go#27455 and golang/go#30185 |
|
I think merge flyteorg/flytestdlib#50 and release a new |
|
@@EngHabu Could you please take a look at this as well? Thanks. |
|
I compiled |
|
Don't understand why it adds all those |
wild-endeavor
previously approved these changes
Dec 18, 2019
honnix
commented
Dec 18, 2019
generate_mocks.sh
Outdated
|
|
||
| # install outside of current module, workaround https://github.com/golang/go/issues/30515 | ||
| # we need to copy go.mod and go.sum because we have a mockery fork | ||
| go_get_mockery () { |
There was a problem hiding this comment.
The reason we cannot turn off module and install is that we need the replace statement in go.mod because we are installing a mockery fork. Turning it off would result installing the original not the fork.
This reverts commit 106ee8e.
honnix
force-pushed
the
go-module-migration
branch
from
d001c8c to
57503a9
Compare
honnix
force-pushed
the
go-module-migration
branch
from
883490b to
1ac0800
Compare
wild-endeavor
added a commit
to flyteorg/boilerplate
that referenced
this pull request
Jan 23, 2020
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
wild-endeavor
previously approved these changes
Jan 24, 2020
|
LGTM now but I cannot approve myself. :) |
EngHabu
approved these changes
Jan 24, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* migrate to go module * install mockery * do not always download pflags * latest version of flytestdlib * refomat * Revert "refomat" This reverts commit b30109297ce71b8f40e9cfab60b2db9d1dd8ad06. * mockery * mockery * sum * test * test * test * test * test * Update .travis.yml * Update Makefile * Update Makefile * move it to the right place * install mockery in a temp folder * add comments * upgrade flytestdlib * go mod tidy * add h1 sum * test * rebase from master * latest flytestdlib * install pflags in tmp folder * change go version back * add comment * incorporate latest boilerplate changes * rely on Makefile to install mockery * updated boilerplate * use install instead * actually adding the new boilerplate entry and updating again * removing unnecessary files * no need for replacement in root go.mod Co-authored-by: Yee Hing Tong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.