Added test for core #285
Closed
Added test for core #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuvraj <[email protected]>
yindia
force-pushed
the
feature/core-pytest
branch
2 times, most recently
from
a25d17d to
e5c8fe5
Compare
EngHabu
reviewed
Jun 11, 2021
.github/workflows/pull_request.yml
Outdated
| - name: Generate Serialize proto | ||
| run: | | ||
| make -C cookbook/core serialize | ||
| - name: run pytest #TODO | ||
| run: make -C coonbook/core test |
There was a problem hiding this comment.
Suggested change
| run: make -C coonbook/core test | |
| run: make -C cookbook/core test |
|
No need to review it. it's a draft pr |
yindia
force-pushed
the
feature/core-pytest
branch
from
e5c8fe5 to
b8e3b70
Compare
Signed-off-by: Yuvraj <[email protected]>
yindia
force-pushed
the
feature/core-pytest
branch
from
b8e3b70 to
80f5cc3
Compare
|
closing it because I moving the entire logic of testing in flytetools/flytetester. In flytetools i will add flytesnacks as submodule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make registerwill change after my other pr automatically Migrate register from docker to flytectl #257Fixes :