Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Use functional test scripts to replace e2e tests #946

Closed
yindia opened this issue Apr 27, 2021 · 5 comments · Fixed by #927
Closed

[Housekeeping] Use functional test scripts to replace e2e tests #946

yindia opened this issue Apr 27, 2021 · 5 comments · Fixed by #927
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@yindia
Copy link
Contributor

yindia commented Apr 27, 2021

Describe the Issue

  • Improve Get Started guide
  • Add GitHub workflow for e2e test on different runner

What if we do not do this?

  • Flytesnacks github workflow to automatically serialize all the examples into *.pb files split into 3 folders (p0, p1 and p2).
    1. Store the serialized workflows as release assets in flytesnacks
    2. Drive the p0, p1 and p2 categorization based on a manually updated manifest file in the same repo.
  • Update getting started to use Flytectl register using these generated assets
  • Publish kustomize manifests in github.com/flyteorg/flyte/releases assets
  • Test Suite Executor github workflow to run on different runners. Initially only support github’s default ubunut-latest but later we can add flyte-aws runner that runs on an EC2 machine and has permissions to create EKS clusters… etc.
    1. The workflow steps should be generic enough to apply to different runners
    2. Support manual invocation

Related component
Either Specific / all

@yindia yindia added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Apr 27, 2021
@yindia yindia reopened this Apr 29, 2021
@kumare3
Copy link
Contributor

kumare3 commented May 27, 2021

@evalsocket whats the progress on this?

@yindia
Copy link
Contributor Author

yindia commented May 29, 2021

  • Flytesnack serialize proto is released in Github
  • Publish flyte manifest in github release
  • Github workflow
  • Python Script @eapolinario [In progress]
  • CI Pipeline Sandbox
  • Ci pipeline for AWS

@yindia
Copy link
Contributor Author

yindia commented Jun 3, 2021

@kumare3 3 task are remaining. @samhita-alla is working on pytest-flyte, I will start other remaining issue after samhita is done with pytest-flyte

@kumare3
Copy link
Contributor

kumare3 commented Jul 3, 2021

@evalsocket is this still valid?

@kumare3 kumare3 added this to the 0.16.0 milestone Jul 3, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu removed this from the 0.17.0 milestone Sep 2, 2021
@yindia yindia added this to the 0.19.0 - Eagle milestone Dec 8, 2021
@EngHabu EngHabu changed the title [Housekeeping] Improve Get Started guide [Housekeeping] Use functional test scripts to replace e2e tests Dec 8, 2021
@yindia
Copy link
Contributor Author

yindia commented Dec 10, 2021

@EngHabu I created a separate issue for reaming task #1932, I am closing this for now

@yindia yindia closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants