Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bumping go version to 1.19 #523

Closed
wants to merge 11 commits into from
Closed

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Feb 6, 2023

TL;DR

Bumping the go version to 1.19 to fix pull request checks.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
EngHabu previously approved these changes Feb 7, 2023
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to start from the top of the tree? stdlib/idl... etc.? to capture the updated deps as you go

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw marked this pull request as draft February 7, 2023 15:59
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #523 (37732c1) into master (2014630) will not change coverage.
The diff coverage is 0.00%.

@hamersaw hamersaw marked this pull request as ready for review February 7, 2023 18:38
@hamersaw
Copy link
Contributor Author

hamersaw commented Feb 7, 2023

closing because these changes were included in #516

@hamersaw hamersaw closed this Feb 7, 2023
@hamersaw hamersaw deleted the housekeeping/bump-go-version branch February 7, 2023 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants