This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Updating PodTemplateStore API #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
previously approved these changes
Feb 2, 2023
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
…plate Signed-off-by: Daniel Rammer <[email protected]>
eapolinario
approved these changes
Feb 7, 2023
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* updated pod template store handling Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl Signed-off-by: Daniel Rammer <[email protected]> * updating flyteplugins Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl and flyteplugins versions Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl and flyteplugins Signed-off-by: Daniel Rammer <[email protected]> * bumping go version to 1.19 Signed-off-by: Daniel Rammer <[email protected]> * fixed linter Signed-off-by: Daniel Rammer <[email protected]> * bumping setup-go action Signed-off-by: Daniel Rammer <[email protected]> * using different flytetools branch Signed-off-by: Daniel Rammer <[email protected]> * fixed go generate Signed-off-by: Daniel Rammer <[email protected]> * using master branch of flytetools Signed-off-by: Daniel Rammer <[email protected]> * removed secrets from unit tests Signed-off-by: Daniel Rammer <[email protected]> * maybe surround go-version in quotes Signed-off-by: Daniel Rammer <[email protected]> * specific 1.19.5 version Signed-off-by: Daniel Rammer <[email protected]> * moved go-version before secrets Signed-off-by: Daniel Rammer <[email protected]> * OMG Signed-off-by: Daniel Rammer <[email protected]> * updated flyte deps Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR updates the PodTemplateStore API to enable
PodTemplateconfiguration at the task granularity.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3123
Follow-up issue
NA