This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
disable k8s controller-runtime manager metrics server #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metrics server Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Closed
2 tasks
kumare3
approved these changes
Oct 11, 2022
Ln11211
pushed a commit
to Ln11211/flytepropeller
that referenced
this pull request
Oct 18, 2022
* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]>
hamersaw
added a commit
that referenced
this pull request
Oct 24, 2022
* Update config.go Set the default values to 0 Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> * disable k8s controller-runtime manager metrics server (#492) * setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * fix: Add servicename in certs (#491) Before: A hardcoded string was used for setting the secret namespace After: The value for the secret namespace for settings is grabbed dynamically. Signed-off-by: Francisco J. Solis <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * Update config.go Removed DefaultDeadlines Signed-off-by: Ln11211 <[email protected]> Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: Francisco J. Solis <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Update config.go Set the default values to 0 Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> * disable k8s controller-runtime manager metrics server (flyteorg#492) * setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer <[email protected]> * and now in the webhook Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * fix: Add servicename in certs (flyteorg#491) Before: A hardcoded string was used for setting the secret namespace After: The value for the secret namespace for settings is grabbed dynamically. Signed-off-by: Francisco J. Solis <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Signed-off-by: Ln11211 <[email protected]> * Update config.go Removed DefaultDeadlines Signed-off-by: Ln11211 <[email protected]> Signed-off-by: LN <[email protected]> Signed-off-by: Ln11211 <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Francisco J. Solis <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: Francisco J. Solis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
In networking setups where k8s requires Pods serving webhooks to have
hostNetwork: truedeployments may suffer "unable to bind address :8080" in the flyte-pod-webhook deployment. This is because both flytepropeller and the pod-webhook pods use the k8s controller-runtime manager internally to manager k8s informers, caches, etc. A component of the controller-runtime manager is the metrics server, which serves prometheus metrics. In the above scenario, if the flytepropeller and pod-webhook pods are deployed on the same host there will be collisions. This PR disables the controller-runtime manager metrics server.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2974
Follow-up issue
flyteorg/flyte#2975 - we should serve the k8s controller-runtime manager metrics using FlytePropellers existing prometheus endpoint by using a separate registry.