Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] serve k8s controller-runtime manager metrics in flytepropeller #2975

Closed
2 tasks done
hamersaw opened this issue Oct 10, 2022 · 0 comments
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@hamersaw
Copy link
Contributor

Motivation: Why do you think this is important?

Currently FlytePropeller uses a k8s controller-runtime manager to aid in k8s informers, caches, etc. This tool includes a metrics endpoint which serves prometheus metrics. In this PR that metrics endpoint was disabled to enable Flyte deployments in environments where host networking is required on webhooks.

Goal: What should the final outcome look like, ideally?

FlytePropeller already includes a prometheus endpoint to serve Flyte specific prometheus metrics. We can include the registry from the k8s controller-runtime manager in this endpoint and serve them alongside the Flyte metrics.

Describe alternatives you've considered

Leaving this as is means that these verbose metrics are unavailable.

Propose: Link/Inline OR Additional context

This is where the k8s controller-runtime manager uses the metrics listener to serve prometheus metrics - https://github.com/kubernetes-sigs/controller-runtime/blob/8ad090e0663e046c5a9dad68a572af0e30626c85/pkg/manager/internal.go#L325-L338

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 10, 2022
@hamersaw hamersaw added this to the 1.3.0-candidate milestone Oct 10, 2022
@cosmicBboy cosmicBboy removed this from the 1.3.0-candidate milestone Jan 23, 2023
@hamersaw hamersaw closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants