This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixing additional truncation of Error #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
EngHabu
reviewed
Aug 26, 2022
| @@ -40,7 +39,7 @@ type Config struct { | |||
| MaxPluginPhaseVersions int32 `json:"max-plugin-phase-versions" pflag:",Maximum number of plugin phase versions allowed for one phase."` | |||
| BarrierConfig BarrierConfig `json:"barrier" pflag:",Config for Barrier implementation"` | |||
| BackOffConfig BackOffConfig `json:"backoff" pflag:",Config for Exponential BackOff implementation"` | |||
| MaxErrorMessageLength int `json:"maxLogMessageLength" pflag:",Max length of error message."` | |||
| MaxErrorMessageLength int `json:"maxLogMessageLength" pflag:",Deprecated!!! Max length of error message."` | |||
There was a problem hiding this comment.
Do we have this config in two places? is that why? can you add that to the deprecation message? "Use Blah.Blah.MaxErrorMessageLength" ?
There was a problem hiding this comment.
no this is not used.
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
hamersaw
approved these changes
Sep 20, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Fixing additional truncation of Error Signed-off-by: Ketan Umare <[email protected]> * added trunc message Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * lint fix Signed-off-by: Ketan Umare <[email protected]> * fixed generate Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Ketan Umare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ketan Umare [email protected]
TL;DR
Removes extra trimming of error message and keeps the 100KB default inplace. Also adds a better message to indicate trimming
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#2818