Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] FlytePropeller trims error message, proactively #2818

Closed
2 tasks done
kumare3 opened this issue Aug 26, 2022 · 0 comments · Fixed by flyteorg/flytepropeller#478
Closed
2 tasks done

[BUG] FlytePropeller trims error message, proactively #2818

kumare3 opened this issue Aug 26, 2022 · 0 comments · Fixed by flyteorg/flytepropeller#478
Assignees
@kumare3
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Aug 26, 2022

Describe the bug

CAses in which the flytekit generated error is more than 2KB (default), flytepropeller simply truncates the message.
This is undesirable. Moreover, there is a default trimming done for all events at 100KB threshold

Expected behavior

100KB+ messages are trimmed and a trimmed indicator is added

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Aug 26, 2022
@kumare3 kumare3 added this to the 1.2.0 milestone Aug 26, 2022
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 26, 2022
@kumare3 kumare3 self-assigned this Aug 26, 2022
@kumare3 kumare3 mentioned this issue Aug 26, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumare3 kumare3

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fixing additional truncation of Error flyteorg/flytepropeller
1 participant
@kumare3