Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Check for no nodes during workflow compilation #187

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Check for no nodes during workflow compilation #187

merged 1 commit into from
Sep 18, 2020

Conversation

katrogan
Copy link
Contributor

TL;DR

Users frequently run into errors at runtime when no nodes are defined for a workflow graph but this can be caught at registration time to reduce confusion & iteration time.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

flyteorg/flyte#314

Follow-up issue

@katrogan katrogan changed the title Check for nodes during workflow compilation Check for no nodes during workflow compilation Sep 18, 2020
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@codecov-commenter
Copy link

Codecov Report

Merging #187 into master will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@katrogan katrogan merged commit 7775cf7 into master Sep 18, 2020
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants