This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix integration tests #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
anandswaminathan,
EngHabu,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 61.27% 61.27%
=======================================
Files 105 105
Lines 7267 7267
=======================================
Hits 4453 4453
Misses 2247 2247
Partials 567 567
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wild-endeavor
previously approved these changes
Sep 22, 2020
EngHabu
previously approved these changes
Sep 23, 2020
katrogan
dismissed stale reviews from EngHabu and wild-endeavor
via
01ac2a2
|
@EngHabu can I get one last review please? |
|
+1 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
flyteorg/flytepropeller#187 adds a check to flytepropeller so that a workflow lacking nodes fails during registration/compilation time. Admin integration tests use incomplete workflow skeletons that do not include any nodes and therefore fail.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/