Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bump Plugins Version #158

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Bump Plugins Version #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38dcd32
Test plugins
Jun 16, 2020
cc0cdcd
Update PhaseInfoInitializing
Jun 16, 2020
29d34eb
bump plugins
Jun 17, 2020
b60302d
Bump plugins version
Jun 17, 2020
e44b3e1
Merge master
Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/jmespath/go-jmespath v0.3.0 // indirect
github.com/lyft/datacatalog v0.2.1
github.com/lyft/flyteidl v0.17.32
github.com/lyft/flyteplugins v0.3.32
github.com/lyft/flyteplugins v0.3.33
github.com/lyft/flytestdlib v0.3.7
github.com/magiconair/properties v1.8.1
github.com/mattn/go-colorable v0.1.6 // indirect
Expand Down
5 changes: 3 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,9 @@ github.com/lyft/datacatalog v0.2.1/go.mod h1:ktrPvzTDUwHO5Lv0hLH38zLHnOJ++rGoAO0
github.com/lyft/flyteidl v0.17.0/go.mod h1:/zQXxuHO11u/saxTTZc8oYExIGEShXB+xCB1/F1Cu20=
github.com/lyft/flyteidl v0.17.32 h1:Iio3gYjTyPhAiOMWJ/H/4YtfWIZm5KZSlWMULT1Ef6U=
github.com/lyft/flyteidl v0.17.32/go.mod h1:/zQXxuHO11u/saxTTZc8oYExIGEShXB+xCB1/F1Cu20=
github.com/lyft/flyteplugins v0.3.32 h1:+qT1apBSjZ0iAig96P+yP1/mUiklZt8VO4LVqvazZzI=
github.com/lyft/flyteplugins v0.3.32/go.mod h1:HHO6KC/2z77n9o9KM697YvSP85IWDe6jl6tAIrMLqWU=

github.com/lyft/flyteplugins v0.3.33 h1:KlNywKdTWpGennWLjBLFnPYTQbnYOsDoQ8fZ8U3gXOQ=
github.com/lyft/flyteplugins v0.3.33/go.mod h1:HHO6KC/2z77n9o9KM697YvSP85IWDe6jl6tAIrMLqWU=
github.com/lyft/flytestdlib v0.3.0/go.mod h1:LJPPJlkFj+wwVWMrQT3K5JZgNhZi2mULsCG4ZYhinhU=
github.com/lyft/flytestdlib v0.3.3 h1:MkWXPkwQinh6MR3Yf5siZhmRSt9r4YmsF+5kvVVVedE=
github.com/lyft/flytestdlib v0.3.3/go.mod h1:LJPPJlkFj+wwVWMrQT3K5JZgNhZi2mULsCG4ZYhinhU=
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/nodes/task/event_recorder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func TestBufferedEventRecorder(t *testing.T) {
assert.NotNil(t, bev)
assert.Equal(t, bev.GetAll(ctx), []pluginCore.PhaseInfo{})

ev1 := pluginCore.PhaseInfoInitializing(time.Now(), 0, "starting")
ev1 := pluginCore.PhaseInfoInitializing(time.Now(), 0, "starting", nil)
assert.NoError(t, bev.RecordRaw(ctx, ev1))
assert.Equal(t, bev.GetAll(ctx), []pluginCore.PhaseInfo{ev1})

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (n NextPhaseStatePlugin) Handle(ctx context.Context, tCtx pluginCore.TaskEx
case pluginCore.PhaseNotReady:
return pluginCore.DoTransition(pluginCore.PhaseInfoNotReady(time.Now(), s.PhaseVersion, "not-ready")), nil
case pluginCore.PhaseInitializing:
return pluginCore.DoTransition(pluginCore.PhaseInfoInitializing(time.Now(), s.PhaseVersion, "initializing")), nil
return pluginCore.DoTransition(pluginCore.PhaseInfoInitializing(time.Now(), s.PhaseVersion, "initializing", s.TaskInfo)), nil
case pluginCore.PhaseQueued:
return pluginCore.DoTransition(pluginCore.PhaseInfoQueued(time.Now(), s.PhaseVersion, "queued")), nil
case pluginCore.PhaseRunning:
Expand Down