Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bump Plugins Version #158

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Bump Plugins Version #158

merged 5 commits into from
Jun 17, 2020

Conversation

akhurana001
Copy link
Contributor

@akhurana001 akhurana001 commented Jun 16, 2020

TL;DR

Bump Plugins Version + handle pluginCore.PhaseInfoInitializing inputs update.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#352

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@kumare3
Copy link
Contributor

kumare3 commented Jun 16, 2020

lint failed!

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

@kumare3
Copy link
Contributor

kumare3 commented Jun 17, 2020

Improve the description please

@akhurana001 akhurana001 changed the title Test plugins Bump Plugins Version Jun 17, 2020
@wild-endeavor
Copy link
Contributor

is there a gh issue?

@wild-endeavor
Copy link
Contributor

is this a breaking change? sorry i don't remember how widespread this function is PhaseInfoInitializing

@akhurana001
Copy link
Contributor Author

is this a breaking change? sorry i don't remember how widespread this function is PhaseInfoInitializing

Added the github issue. I didn't see any other references to it and I am guessing the build succeeded so we should be good ?

@akhurana001 akhurana001 merged commit 24736e3 into master Jun 17, 2020
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
* Test plugins

* Update PhaseInfoInitializing

* bump plugins

* Bump plugins version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants