Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Specify how resource is cleaned up #274

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

SmritiSatyanV
Copy link
Contributor

Specify how resource is cleaned up after successful execution of a k8s pod
Issue
Signed-off-by: SmritiSatyanV [email protected]

Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](flyteorg/flyte#2650)
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>
@welcome
Copy link

welcome bot commented Jul 5, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #274 (1c60746) into master (4c4af21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   62.97%   62.97%           
=======================================
  Files         142      142           
  Lines        8970     8970           
=======================================
  Hits         5649     5649           
  Misses       2799     2799           
  Partials      522      522           
Flag Coverage Δ
unittests 62.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4af21...1c60746. Read the comment docs.

@SmritiSatyanV SmritiSatyanV merged commit 902b902 into master Jul 5, 2022
@welcome
Copy link

welcome bot commented Jul 5, 2022

Congrats on merging your first pull request! 🎉

eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](flyteorg/flyte#2650)
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants