Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Document how resources are cleaned up after successful execution #2650

Closed
2 tasks done
SmritiSatyanV opened this issue Jun 30, 2022 · 0 comments
Closed
2 tasks done

[Docs] Document how resources are cleaned up after successful execution #2650

SmritiSatyanV opened this issue Jun 30, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers

Comments

@SmritiSatyanV
Copy link
Contributor

Description

Slack conversation
Document where it has to be mentioned.
The default behavior of failure handling is abort (instead of finalize). Abort deletes the k8s Pod, whereas finalize requires the delete-resource-on-finalize flag to be set to delete the resource. Currently, no configuration changes are required to ensure resource clean-up during failure.
Document delete-resource-on-finalize clearly to suggest that when a k8s Pod execution is successful, the pod is deleted rather than allowing the k8s garbage collector to clean it up.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@SmritiSatyanV SmritiSatyanV added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Jun 30, 2022
SmritiSatyanV added a commit that referenced this issue Jun 30, 2022
@SmritiSatyanV
Specify how resource is cleaned up
5b30c81 
Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](#2650)
Signed-off-by: SmritiSatyanV <[email protected]>


Signed-off-by: SmritiSatyanV <[email protected]>
@SmritiSatyanV SmritiSatyanV mentioned this issue Jun 30, 2022
Closed
SmritiSatyanV added a commit to flyteorg/flyteplugins that referenced this issue Jul 5, 2022
@SmritiSatyanV
Specify how resource is cleaned up
1c60746 
Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](flyteorg/flyte#2650)
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>
@SmritiSatyanV SmritiSatyanV mentioned this issue Jul 5, 2022
Merged
SmritiSatyanV added a commit to flyteorg/flyteplugins that referenced this issue Jul 5, 2022
@SmritiSatyanV
Specify how resource is cleaned up (#274)
902b902 
Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](flyteorg/flyte#2650)
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>
pingsutw pushed a commit to pingsutw/flyte-monorepo that referenced this issue Apr 4, 2023
@SmritiSatyanV
Specify how resource is cleaned up (#274)
574bd14 
Specify how resource is cleaned up after successful execution of a k8s pod
[Issue](flyteorg/flyte#2650)
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SmritiSatyanV