Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pull in origin from error document #patch #188

Merged
merged 7 commits into from
Jul 12, 2021
Merged

Pull in origin from error document #patch #188

merged 7 commits into from
Jul 12, 2021

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jul 9, 2021

Signed-off-by: wild-endeavor [email protected]

TL;DR

Now that this is in, flyteorg/flytekit#543, we can pull it in.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Had to update the stdlib version cuz the newer one contains the mock I needed to test.
  • Ran make generate
  • Updated the behavior of the unit test for config loading, we're overriding now instead of merging.

Signed-off-by: wild-endeavor <[email protected]>
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #188 (1ed400d) into master (e787bc7) will decrease coverage by 0.04%.
The diff coverage is 1.31%.

❗ Current head 1ed400d differs from pull request most recent head 9a606b9. Consider uploading reports for the commit 9a606b9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   60.54%   60.50%   -0.05%     
==========================================
  Files         135      135              
  Lines        7371     8264     +893     
==========================================
+ Hits         4463     5000     +537     
- Misses       2458     2806     +348     
- Partials      450      458       +8     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/aws/config_flags.go 24.00% <0.00%> (-5.42%) ⬇️
go/tasks/config/config_flags.go 17.39% <0.00%> (-2.61%) ⬇️
go/tasks/logs/logconfig_flags.go 42.42% <0.00%> (-9.58%) ⬇️
go/tasks/pluginmachinery/catalog/config_flags.go 32.14% <0.00%> (-7.86%) ⬇️
...machinery/flytek8s/config/k8spluginconfig_flags.go 47.22% <0.00%> (-9.93%) ⬇️
...sks/pluginmachinery/webapi/example/config_flags.go 36.66% <0.00%> (-8.79%) ⬇️
...tasks/pluginmachinery/webapi/pluginconfig_flags.go 36.66% <0.00%> (-8.79%) ⬇️
...asks/plugins/array/awsbatch/config/config_flags.go 55.81% <0.00%> (-9.91%) ⬇️
go/tasks/plugins/array/k8s/config_flags.go 54.76% <0.00%> (-9.95%) ⬇️
go/tasks/plugins/hive/config/config_flags.go 34.48% <0.00%> (-8.38%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e787bc7...9a606b9. Read the comment docs.

Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
@wild-endeavor wild-endeavor changed the title errors Pull in origin from error document #patch Jul 9, 2021
@wild-endeavor wild-endeavor marked this pull request as ready for review July 9, 2021 22:58
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
@wild-endeavor wild-endeavor merged commit a20bca7 into master Jul 12, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants