Clean up scopes and exception handling for new tasks #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 85.37% 85.44% +0.07%
==========================================
Files 371 371
Lines 28722 28857 +135
Branches 2310 2310
==========================================
+ Hits 24520 24658 +138
+ Misses 3563 3561 -2
+ Partials 639 638 -1
Continue to review full report at Codecov.
|
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
wild-endeavor
changed the title
Signed-off-by: wild-endeavor <[email protected]>
kumare3
reviewed
Jul 9, 2021
| outputs = task_def.dispatch_execute(ctx, idl_input_literals) | ||
| # Decorate the dispatch execute function before calling it, this wraps all exceptions into one | ||
| # of the FlyteScopedExceptions | ||
| outputs = _scoped_exceptions.system_entry_point(task_def.dispatch_execute)(ctx, idl_input_literals) |
There was a problem hiding this comment.
omg, this is weird?
why not a simple
try:
outputs = ....
except :
...
There was a problem hiding this comment.
This is effectively what the decorator does. The reason the decorator exists is mostly for two reasons:
- We enter and leave user-code in multiple places,
- The excpetions that we, flytekit authors, throw do not conform to any hierarchy easily distinguishable from potential user exceptions. After we complete [Housekeeping] [flytekit] Exception cleanup flyte#1033, and all flytekit exceptions have a base class that users will never use, we can get rid of these scoped exceptions and just use a few try catches to distinguish things.
I think it's preferable to get rid of these scoped exceptions actually, I just don't want to go through everything and update them right now. Maybe at 1.0
kumare3
reviewed
Jul 9, 2021
| the last case in the nested try/catch below. | ||
|
|
||
| Decorator for wrapping functions that enter a system context. This should decorate every method that may invoke some | ||
| user code later on down the line. This will allow us to add differentiation between what is a user error and |
There was a problem hiding this comment.
user code later on down the line. This will allow us to add differentiation between what is a
WHY not at the point where the user code is called? i.e. only the last parent of the user code function?
There was a problem hiding this comment.
See comment above.
kumare3
approved these changes
Jul 9, 2021
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This cleans up the exception handling of new tasks and workflows. Currently there is no differentiation of recoverable or non-recoverable errors and all errors were system errors.
Type
Are all requirements met?
Complete description
kindinto theExecutionErrormodel.origininto theContainerError._dispatch_executein the entrypoint.py.