This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
feat; allow users choose raw output path style (sharded, non sharded, human readable etc) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2020 23:04
- Prefix sharding is only useful for S3 and specifically for provisioned buckets - For buckets that are not provisioned for high throughput, it might be useful to use no sharding to make it easy to find the path - The path option is still not human readable but derivable
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 58.72% 58.75% +0.03%
==========================================
Files 99 99
Lines 5938 5957 +19
==========================================
+ Hits 3487 3500 +13
- Misses 2103 2106 +3
- Partials 348 351 +3
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Aug 27, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
… human readable etc) (#116)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently we store data in 2 char shards always. This is useful only at the root of a pre-sharded S3 bucket. This change makes it possible to not have to use the 2 char shard, but Flyte will automatically generate a shard in your bucket where to write the data
Type
Are all requirements met?
Complete description
This will enable capability to not create shard chars when not required.
provisioned buckets
useful to use no sharding to make it easy to find the path
Tracking Issue
flyteorg/flyte#486
Follow-up issue
NA