Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Don't override sidecar tolerations #104

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Don't override sidecar tolerations #104

merged 1 commit into from
Jul 20, 2020

Conversation

katrogan
Copy link
Contributor

TL;DR

Update sidecar task plugin to append to existing user-specified tolerations (if any).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Thank you @rstanevich for finding and reporting!

Tracking Issue

flyteorg/flyte#417

Follow-up issue

NA

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

Merging #104 into master will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   59.76%   59.74%   -0.02%     
==========================================
  Files          95       95              
  Lines        5331     5334       +3     
==========================================
+ Hits         3186     3187       +1     
- Misses       1844     1845       +1     
- Partials      301      302       +1     
Impacted Files Coverage Δ
go/tasks/plugins/k8s/sidecar/sidecar.go 75.72% <60.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf37142...8228ccd. Read the comment docs.

Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@katrogan katrogan merged commit e4ee895 into master Jul 20, 2020
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants