Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [flyteplugins][sidecar_task] Throw Tolerations from pod_spec into Pod manifest #417

Closed
7 of 20 tasks
rstanevich opened this issue Jul 17, 2020 · 0 comments
Closed
7 of 20 tasks

[BUG] [flyteplugins][sidecar_task] Throw Tolerations from pod_spec into Pod manifest #417

rstanevich opened this issue Jul 17, 2020 · 0 comments
Assignees
@katrogan
Labels
bug Something isn't working
Milestone
0.6.0

Comments

@rstanevich
Copy link
Contributor

Describe the bug
The sidecar_task ignores tolerations which set in pod_spec argument.
https://lyft.github.io/flyte/user/tasktypes/sidecar.html?highlight=pod_spec#working-example

Expected behavior
The option to set tolerations section via pod_spec for sidecar_task.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Create sidecar_task workflow and set tolerations section in the pod_spec
  2. Run workflow
  3. Check running Pod manifest - it doesn't contain tolerations which was set in pod_spec

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
according to @katrogan notes in slack:
https://github.com/lyft/flyteplugins/blob/v0.3.36/go/tasks/plugins/k8s/sidecar/sidecar.go#L64
The tolerations section is dropped from the pod_spec.
@rstanevich rstanevich added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 17, 2020
@katrogan katrogan self-assigned this Jul 17, 2020
@katrogan katrogan mentioned this issue Jul 20, 2020
Merged
8 tasks
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 25, 2020
@wild-endeavor wild-endeavor added this to the 0.6.0 milestone Jul 27, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Reporting more complete metadata for map task subtasks (flyteorg#417)
53dcd04 
* fixed potential nil pointer

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

* added CacheStatus and Logs fields to ExternalResourceInfo proto

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* setting TaskExecutionEvent version to 1

Signed-off-by: Daniel Rammer <[email protected]>

* bumped flyteidl and flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pmahindrakar-oss
Added grpc health probe binary for readiness and liveness check (flyt…
6d29768 
…eorg#417)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@samhita-alla
Feast docs (flyteorg#417)
a8e90a2 
* Feast docs

Signed-off-by: Samhita Alla <[email protected]>

* remove sqlite docs

Signed-off-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@MorpheusXAUT
Add interruptible override to launch forms #chore (flyteorg#417)
919e90c 
* Added interruptible override for executions
Workflows and tasks can now have their interruptible flag set for a single execution
Added indication about interruptible override to execution metadata

* Interruptible override now includes indeterminate state
Defaults to indeterminate state, allowing for executions to have their interruptible setting overriden to  and
Added text indicator for override status to checkbox label

* Use released @flyteorg/flyteidl package
* Added extra tests 
Signed-off-by: Nick Müller <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Reporting more complete metadata for map task subtasks (flyteorg#417)
c4553bb 
* fixed potential nil pointer

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

* added CacheStatus and Logs fields to ExternalResourceInfo proto

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteidl

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* setting TaskExecutionEvent version to 1

Signed-off-by: Daniel Rammer <[email protected]>

* bumped flyteidl and flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pmahindrakar-oss
Added grpc health probe binary for readiness and liveness check (flyt…
491cb93 
…eorg#417)
mhotan added a commit to mhotan/flyte that referenced this issue Aug 28, 2024
@mhotan
Make adminOauthClientCredentials secret name configurable (flyteorg#417)
75c3fcb 
* Make adminOauthClientCredentials secret name configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@katrogan @wild-endeavor @rstanevich