Concise dynamic node ids and names #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PART 1: - Dynamic node ids currently have additional context, namely a shortened name of the dynamic task function - This causes a tremendous bloat and is completely dependent on the name of the task - This PR standardizes the name and affixes a simple `d` in the begining PART 2: Reduce node names, which are purely for decorative purposes Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
EngHabu
previously approved these changes
Oct 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 85.70% 85.72% +0.01%
==========================================
Files 355 356 +1
Lines 29703 29717 +14
Branches 2426 2428 +2
==========================================
+ Hits 25457 25474 +17
+ Misses 3605 3603 -2
+ Partials 641 640 -1
Continue to review full report at Codecov.
|
Signed-off-by: Ketan Umare <[email protected]>
|
This won't work in certain dynamic cases if users are on the old version of Admin right? before the proper node to node relationship was done. Should we call that out? |
wild-endeavor
approved these changes
Oct 15, 2021
This changed with flyteorg/flyteadmin#111 ? |
|
@wild-endeavor we have defaulted to node to node versions now. so it is the default |
eapolinario
approved these changes
Oct 15, 2021
Comment on lines
+738
to
+739
| if name is None: | ||
| return "" |
There was a problem hiding this comment.
nit: we shouldn't need this, right?
aeioulisa
pushed a commit
to aeioulisa/flytekit
that referenced
this pull request
Oct 19, 2021
* Concise: dynamic node ids and names PART 1: - Dynamic node ids currently have additional context, namely a shortened name of the dynamic task function - This causes a tremendous bloat and is completely dependent on the name of the task - This PR standardizes the name and affixes a simple `d` in the begining PART 2: Reduce node names, which are purely for decorative purposes Signed-off-by: Ketan Umare <[email protected]> * unit tests Signed-off-by: Ketan Umare <[email protected]> * fix test Signed-off-by: Ketan Umare <[email protected]> * unit tests Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Lisa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
PART 1:
a shortened name of the dynamic task function
name of the task
din thebegining
PART 2:
Reduce node names, which are purely for decorative purposes
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#1660
Follow-up issue
NA