unit tests

Signed-off-by: Ketan Umare <[email protected]>

flytekit/common/utils.py

@@ -11,7 +11,7 @@
 from flytekit.models.core import identifier as _identifier
 
 
-def _dnsify(value):  # type: (str) -> str
+def _dnsify(value: str) -> str:
     """
     Converts value into a DNS-compliant (RFC1035/RFC1123 DNS_LABEL). The resulting string must only consist of
     alphanumeric (lower-case a-z, and 0-9) and not exceed 63 characters. It's permitted to have '-' character as long

flytekit/core/workflow.py

@@ -187,7 +187,7 @@ def name(self) -> str:
 
     @property
     def short_name(self) -> str:
-        return self._name.split(".")[-1]
+        return extract_obj_name(self._name)
 
     @property
     def workflow_metadata(self) -> Optional[WorkflowMetadata]:

tests/flytekit/unit/common_tests/test_utils.py

@@ -0,0 +1,22 @@
+import pytest
+
+from flytekit.common.utils import _dnsify
+
+
+@pytest.mark.parametrize(
+    "input,expected",
+    [
+        ("test.abc", "test-abc"),
+        ("test", "test"),
+        ("", ""),
+        (".test", "test"),
+        ("Test", "test"),
+        ("test.", "test"),
+        ("test-", "test"),
+        ("test$", "test"),
+        ("te$t$", "tet"),
+        ("t" * 64, f"da4b348ebe-{'t'*52}"),
+    ],
+)
+def test_dnsify(input, expected):
+    assert _dnsify(input) == expected