Failed to transform path string to Literal #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 355 355
Lines 29682 29684 +2
Branches 2427 2426 -1
=======================================
+ Hits 25434 25436 +2
Misses 3606 3606
Partials 642 642
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Oct 7, 2021
eapolinario
pushed a commit
that referenced
this pull request
Oct 8, 2021
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
AdrianoKF
pushed a commit
to AdrianoKF/flytekit
that referenced
this pull request
Oct 11, 2021
Signed-off-by: Kevin Su <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Oct 19, 2021
* Run 3.9 in CI Signed-off-by: Eduardo Apolinario <[email protected]> * Also run 3.9 in plugins tests. Signed-off-by: Eduardo Apolinario <[email protected]> * Fix tests Signed-off-by: Eduardo Apolinario <[email protected]> * Account for the different exception type raised in case of wrong types Signed-off-by: Eduardo Apolinario <[email protected]> * Exclude spark2 Signed-off-by: Eduardo Apolinario <[email protected]> * Failed to load json_data to dataclass (#684) Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Remove sync singledispatch, add option for top-level only sync (#681) Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Failed to transform path string to Literal (#689) Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Don't node sync on remote wait (#690) * no node sync Signed-off-by: Yee Hing Tong <[email protected]> * add param to wait Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Fix plugin regressions (#688) * fix pandera regression Signed-off-by: Niels Bantilan <[email protected]> * install plugin with pip Signed-off-by: Niels Bantilan <[email protected]> * fix pandera plugin tests Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * add spark flytekit plugin to papermill test_requires Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * add sqlalchemy to great expectations plugin Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> * plugins plugins plugins! Signed-off-by: Niels Bantilan <[email protected]> * lint Signed-off-by: Niels Bantilan <[email protected]> * Exclude does not understand lists Signed-off-by: Eduardo Apolinario <[email protected]> * Invert python version check Signed-off-by: Eduardo Apolinario <[email protected]> * Invert python version check for real this time Signed-off-by: Eduardo Apolinario <[email protected]> * Enable 3.10 just for kicks Signed-off-by: Eduardo Apolinario <[email protected]> * Add quotes around python versions Yes, this is needed, please see https://dev.to/hugovk/the-python-3-1-problem-85g. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Add quotes around python versions" This reverts commit 4d619d5. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Enable 3.10 just for kicks" This reverts commit bd6d694. Signed-off-by: Eduardo Apolinario <[email protected]> * wip - restricted types Signed-off-by: Eduardo Apolinario <[email protected]> * wip - restricted types Signed-off-by: Eduardo Apolinario <[email protected]> * Comment use of restricted types in get_transformer Signed-off-by: Eduardo Apolinario <[email protected]> * Publish 3.9 image Signed-off-by: Eduardo Apolinario <[email protected]> * Add python 3.9 to the list of supported languages Signed-off-by: Eduardo Apolinario <[email protected]> * Comment RestrictedTypeTransformer and add one test case. Signed-off-by: Eduardo Apolinario <[email protected]> * Review feedback Signed-off-by: Eduardo Apolinario <[email protected]> * Comment RestrictedTypeTransformer Signed-off-by: Eduardo Apolinario <[email protected]> * Handle the TypeError Signed-off-by: Eduardo Apolinario <[email protected]> * Remove breakpoint Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Niels Bantilan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Failed to transform path string to Literal
Type
Are all requirements met?
Complete description
Return
FlyteTypeExceptionwhen gettingTypeErrorfromTypeEngine.to_literalTracking Issue
https://flyte-org.slack.com/archives/CREL4QVAQ/p1633567961295600
Follow-up issue
NA