Add official support for python 3.9

[eapolinario]

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

Support python 3.9 officially.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Handle the case where a call to isinstance might raise an exception in calls to isinstance.
isinstance raises an error if the base type is not a valid type in python 3.9, so we now handle a case in the type engine where one of the registered restricted types, namely NamedTuple, is now considered invalid (hence raising TypeError).

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

[samhita-alla]

@eapolinario I just want to give a heads-up about some NamedTuple errors I have come across in Python 3.9.

• [BUG][Flytekit] No NamedTuple attribute '_field_types' in Python 3.9 flyte#1166
• [BUG][Flytekit] Incorrect NamedTuple type in Python 3.9 flyte#1165
• [BUG][Flytekit] NamedTuple AssertionError in Python 3.9 flyte#1154
• [BUG][Flytekit] Calling NamedTuple field on Promise isn't working as expected in Python 3.9 flyte#1153

[codecov]

Codecov Report

Merging #687 (900d444) into master (6c03203) will increase coverage by 0.06%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   85.68%   85.74%   +0.06%     
==========================================
  Files         355      357       +2     
  Lines       29684    29746      +62     
  Branches     2426     2428       +2     
==========================================
+ Hits        25436    25507      +71     
+ Misses       3606     3600       -6     
+ Partials      642      639       -3     

Impacted Files	Coverage Δ
tests/flytekit/unit/core/test_type_hints.py	95.88% <83.33%> (+0.02%)	⬆️
flytekit/core/type_engine.py	88.47% <90.00%> (+0.09%)	⬆️
flytekit/core/workflow.py	89.36% <0.00%> (-0.31%)	⬇️
flytekit/core/base_task.py	89.04% <0.00%> (ø)
flytekit/core/reference_entity.py	91.85% <0.00%> (ø)
tests/flytekit/unit/remote/test_remote.py	100.00% <0.00%> (ø)
tests/flytekit/unit/common_tests/test_promise.py	100.00% <0.00%> (ø)
tests/flytekit/unit/common_tests/test_utils.py	100.00% <0.00%> (ø)
...s/flytekit/unit/core/test_python_auto_container.py	100.00% <0.00%> (ø)
flytekit/core/context_manager.py	92.93% <0.00%> (+0.02%)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c03203...900d444. Read the comment docs.

[eapolinario]

@samhita-alla , were you aware of any other issue that was blocking python 3.9?

[eapolinario]

For those who are wondering, we can't enable 3.10 yet because numpy wheels are missing across the board. According to numpy/numpy#20045 will have to wait for the next numpy release.

[samhita-alla]

@samhita-alla , were you aware of any other issue that was blocking python 3.9?

Not really. The ones I sent were the blockers I had come across.