-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show traceback by default #2862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
October 24, 2024 22:42
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Oct 24, 2024
Future-Outlier
pushed a commit
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Kevin Su <[email protected]>
Future-Outlier
added a commit
that referenced
this pull request
Oct 28, 2024
* Pydantic Transformer V2 Signed-off-by: Future-Outlier <[email protected]> * add __init__.py Signed-off-by: Future-Outlier <[email protected]> * add json schema Signed-off-by: Future-Outlier <[email protected]> * convert float to int Signed-off-by: Future-Outlier <[email protected]> * change gitsha in test script mode Signed-off-by: Future-Outlier <[email protected]> * change gitsha Signed-off-by: Future-Outlier <[email protected]> * use strict map=false Signed-off-by: Future-Outlier <[email protected]> * Test flytefile console input + attr access Signed-off-by: Future-Outlier <[email protected]> * add conditional branch Signed-off-by: Future-Outlier <[email protected]> * better rx Signed-off-by: Future-Outlier <[email protected]> * Add flytedir generic -> flytedir Signed-off-by: Future-Outlier <[email protected]> * support enum Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * add tests for input from flyte console Signed-off-by: Future-Outlier <[email protected]> * Add Tests for dataclass in BaseModel and pydantic.dataclass in BaseModel Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * update thomas's advice Signed-off-by: Future-Outlier <[email protected]> * change tree file structure Signed-off-by: Future-Outlier <[email protected]> * update Niel's advice Signed-off-by: Future-Outlier <[email protected]> * > to >= Signed-off-by: Future-Outlier <[email protected]> * try monodoc build again Signed-off-by: Future-Outlier <[email protected]> * add pydantic README.md Signed-off-by: Future-Outlier <[email protected]> * revert -vvv in monodocs Signed-off-by: Future-Outlier <[email protected]> * use model_validate_json to turn protobuf struct to python val Signed-off-by: Future-Outlier <[email protected]> * fix issue Signed-off-by: Future-Outlier <[email protected]> * handle flyte types in dict transformer from protobuf struct input (e.g FlyteConsole) Signed-off-by: Future-Outlier <[email protected]> * Add print Signed-off-by: Future-Outlier <[email protected]> * expected python type Signed-off-by: Future-Outlier <[email protected]> * switch call function order Signed-off-by: Future-Outlier <[email protected]> * try msgpack to handle protobug struct Signed-off-by: Future-Outlier <[email protected]> * Better Comment in Dict Transformer Signed-off-by: Future-Outlier <[email protected]> * Propeller -> FlytePropeller Signed-off-by: Future-Outlier <[email protected]> * dict_to_flyte_types Signed-off-by: Future-Outlier <[email protected]> * remove comments Signed-off-by: Future-Outlier <[email protected]> * add attr for protobuf struct . dict Signed-off-by: Future-Outlier <[email protected]> * Add Life Cycle for Flyte Types Signed-off-by: Future-Outlier <[email protected]> * better comments for derializing flyteschema and sd Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * add back pv._remote_path = None to flytefile and flytedir Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * Add comments Signed-off-by: Future-Outlier <[email protected]> * update Yee's advice Signed-off-by: Future-Outlier <[email protected]> * code dc -> bm Signed-off-by: Future-Outlier <[email protected]> * Example dc -> bm and Example all flyte types Signed-off-by: Future-Outlier <[email protected]> * fix union dataclass, not yet add comments Signed-off-by: Future-Outlier <[email protected]> * add pydantic and dataclass optional test Signed-off-by: Future-Outlier <[email protected]> * NoneType=type(None) Signed-off-by: Future-Outlier <[email protected]> * fix union transformer none case with Eduardo Signed-off-by: Future-Outlier <[email protected]> * add comments for none type transformer + union transformer Signed-off-by: Future-Outlier <[email protected]> * add TODO Signed-off-by: Future-Outlier <[email protected]> * use deserailize = True Signed-off-by: Future-Outlier <[email protected]> * add all deserialize Signed-off-by: Future-Outlier <[email protected]> * better comments Signed-off-by: Future-Outlier <[email protected]> * better comments Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * Fix flyte directory issue by discussion with Kevin Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> * add tests for providing conext when doing serialization Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * move setattr to core Signed-off-by: Future-Outlier <[email protected]> * remove comments Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * remove Signed-off-by: Future-Outlier <[email protected]> * testing Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * flytekit/core/type_engine.py Signed-off-by: Future-Outlier <[email protected]> * add tests for Union Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * remove nonetype Signed-off-by: Future-Outlier <[email protected]> * raw=Fasle as default Signed-off-by: Future-Outlier <[email protected]> * pydantic move to core test Signed-off-by: Future-Outlier <[email protected]> * move to core Signed-off-by: Future-Outlier <[email protected]> * log Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * move to type_engine Signed-off-by: Future-Outlier <[email protected]> * move back to init Signed-off-by: Future-Outlier <[email protected]> * update kevin's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> * wip Signed-off-by: Future-Outlier <[email protected]> * use decorator Signed-off-by: Future-Outlier <[email protected]> * decorator Signed-off-by: Future-Outlier <[email protected]> * fix syntax to support python 3.9 Signed-off-by: Future-Outlier <[email protected]> * add Eduardo's advice Signed-off-by: Future-Outlier <[email protected]> * warning Signed-off-by: Future-Outlier <[email protected]> * Update Yee's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> * Show traceback by default (#2862) Signed-off-by: Kevin Su <[email protected]> * Support Identifier in generate_console_url (#2868) Signed-off-by: Thomas J. Fan <[email protected]> * Support overriding node metadata for array node (#2865) * set parent node metadata on arraynode subnode Signed-off-by: Paul Dittamo <[email protected]> * clean up setting passed in metadata for array node Signed-off-by: Paul Dittamo <[email protected]> * add comment Signed-off-by: Paul Dittamo <[email protected]> * test Signed-off-by: Paul Dittamo <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> * Fix Jupyter Versioning (#2866) * Update versioning Signed-off-by: Mecoli1219 <[email protected]> * Fix unit test Signed-off-by: Mecoli1219 <[email protected]> * Update path if jupyter file actually exist Signed-off-by: Mecoli1219 <[email protected]> * Fix pickled twice problem Signed-off-by: Mecoli1219 <[email protected]> --------- Signed-off-by: Mecoli1219 <[email protected]> * improved output handling in notebooks (#2869) --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]>
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Kevin Su <[email protected]>
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Pydantic Transformer V2 Signed-off-by: Future-Outlier <[email protected]> * add __init__.py Signed-off-by: Future-Outlier <[email protected]> * add json schema Signed-off-by: Future-Outlier <[email protected]> * convert float to int Signed-off-by: Future-Outlier <[email protected]> * change gitsha in test script mode Signed-off-by: Future-Outlier <[email protected]> * change gitsha Signed-off-by: Future-Outlier <[email protected]> * use strict map=false Signed-off-by: Future-Outlier <[email protected]> * Test flytefile console input + attr access Signed-off-by: Future-Outlier <[email protected]> * add conditional branch Signed-off-by: Future-Outlier <[email protected]> * better rx Signed-off-by: Future-Outlier <[email protected]> * Add flytedir generic -> flytedir Signed-off-by: Future-Outlier <[email protected]> * support enum Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * add tests for input from flyte console Signed-off-by: Future-Outlier <[email protected]> * Add Tests for dataclass in BaseModel and pydantic.dataclass in BaseModel Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * update thomas's advice Signed-off-by: Future-Outlier <[email protected]> * change tree file structure Signed-off-by: Future-Outlier <[email protected]> * update Niel's advice Signed-off-by: Future-Outlier <[email protected]> * > to >= Signed-off-by: Future-Outlier <[email protected]> * try monodoc build again Signed-off-by: Future-Outlier <[email protected]> * add pydantic README.md Signed-off-by: Future-Outlier <[email protected]> * revert -vvv in monodocs Signed-off-by: Future-Outlier <[email protected]> * use model_validate_json to turn protobuf struct to python val Signed-off-by: Future-Outlier <[email protected]> * fix issue Signed-off-by: Future-Outlier <[email protected]> * handle flyte types in dict transformer from protobuf struct input (e.g FlyteConsole) Signed-off-by: Future-Outlier <[email protected]> * Add print Signed-off-by: Future-Outlier <[email protected]> * expected python type Signed-off-by: Future-Outlier <[email protected]> * switch call function order Signed-off-by: Future-Outlier <[email protected]> * try msgpack to handle protobug struct Signed-off-by: Future-Outlier <[email protected]> * Better Comment in Dict Transformer Signed-off-by: Future-Outlier <[email protected]> * Propeller -> FlytePropeller Signed-off-by: Future-Outlier <[email protected]> * dict_to_flyte_types Signed-off-by: Future-Outlier <[email protected]> * remove comments Signed-off-by: Future-Outlier <[email protected]> * add attr for protobuf struct . dict Signed-off-by: Future-Outlier <[email protected]> * Add Life Cycle for Flyte Types Signed-off-by: Future-Outlier <[email protected]> * better comments for derializing flyteschema and sd Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * add back pv._remote_path = None to flytefile and flytedir Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * experiment Signed-off-by: Future-Outlier <[email protected]> * Add comments Signed-off-by: Future-Outlier <[email protected]> * update Yee's advice Signed-off-by: Future-Outlier <[email protected]> * code dc -> bm Signed-off-by: Future-Outlier <[email protected]> * Example dc -> bm and Example all flyte types Signed-off-by: Future-Outlier <[email protected]> * fix union dataclass, not yet add comments Signed-off-by: Future-Outlier <[email protected]> * add pydantic and dataclass optional test Signed-off-by: Future-Outlier <[email protected]> * NoneType=type(None) Signed-off-by: Future-Outlier <[email protected]> * fix union transformer none case with Eduardo Signed-off-by: Future-Outlier <[email protected]> * add comments for none type transformer + union transformer Signed-off-by: Future-Outlier <[email protected]> * add TODO Signed-off-by: Future-Outlier <[email protected]> * use deserailize = True Signed-off-by: Future-Outlier <[email protected]> * add all deserialize Signed-off-by: Future-Outlier <[email protected]> * better comments Signed-off-by: Future-Outlier <[email protected]> * better comments Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * Fix flyte directory issue by discussion with Kevin Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> * add tests for providing conext when doing serialization Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * move setattr to core Signed-off-by: Future-Outlier <[email protected]> * remove comments Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * remove Signed-off-by: Future-Outlier <[email protected]> * testing Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * flytekit/core/type_engine.py Signed-off-by: Future-Outlier <[email protected]> * add tests for Union Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * remove nonetype Signed-off-by: Future-Outlier <[email protected]> * raw=Fasle as default Signed-off-by: Future-Outlier <[email protected]> * pydantic move to core test Signed-off-by: Future-Outlier <[email protected]> * move to core Signed-off-by: Future-Outlier <[email protected]> * log Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * test Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * lint Signed-off-by: Future-Outlier <[email protected]> * move to type_engine Signed-off-by: Future-Outlier <[email protected]> * move back to init Signed-off-by: Future-Outlier <[email protected]> * update kevin's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> * wip Signed-off-by: Future-Outlier <[email protected]> * use decorator Signed-off-by: Future-Outlier <[email protected]> * decorator Signed-off-by: Future-Outlier <[email protected]> * fix syntax to support python 3.9 Signed-off-by: Future-Outlier <[email protected]> * add Eduardo's advice Signed-off-by: Future-Outlier <[email protected]> * warning Signed-off-by: Future-Outlier <[email protected]> * Update Yee's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> * Show traceback by default (#2862) Signed-off-by: Kevin Su <[email protected]> * Support Identifier in generate_console_url (#2868) Signed-off-by: Thomas J. Fan <[email protected]> * Support overriding node metadata for array node (#2865) * set parent node metadata on arraynode subnode Signed-off-by: Paul Dittamo <[email protected]> * clean up setting passed in metadata for array node Signed-off-by: Paul Dittamo <[email protected]> * add comment Signed-off-by: Paul Dittamo <[email protected]> * test Signed-off-by: Paul Dittamo <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> * Fix Jupyter Versioning (#2866) * Update versioning Signed-off-by: Mecoli1219 <[email protected]> * Fix unit test Signed-off-by: Mecoli1219 <[email protected]> * Update path if jupyter file actually exist Signed-off-by: Mecoli1219 <[email protected]> * Fix pickled twice problem Signed-off-by: Mecoli1219 <[email protected]> --------- Signed-off-by: Mecoli1219 <[email protected]> * improved output handling in notebooks (#2869) --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The error message is not helpful in some cases when verbosity is 0.
What changes were proposed in this pull request?
print the traceback by default
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA