Support overriding node metadata for array node #2865
+45
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes: https://linear.app/unionai/issue/COR-2090/enable-caching-when-mapping-over-launchplans
Why are the changes needed?
with_overrides doesn't work for array node.
solution:
map_task(my_wf_lp)(a=[1, 2, 3], b=[4, 5, 6]).with_overrides(cache=True, cache_version="3.0")
overrides node metadata for the node that encompasses the array node. This is then copied down into the array node's subnode causing for the node metadata to then be utilized when the nodes are executed. Note, the parent node's node metadata isn't utilized in propeller.
NodeMetadata also doesn't really apply to the parent ArrayNode
Alternative could be to set something like:
map_task(my_wf_lp.with_overrides(cache=True, cache_version="3.0")
)(a=[1, 2, 3], b=[4, 5, 6])but that would require some substantial changes with LaunchPlan and differs from the current understanding of with_overrides
What changes were proposed in this pull request?
cleaned up a little code:
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link