Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to disable default launch plan generation #170

Merged
merged 6 commits into from
Sep 2, 2020
Merged

Add a flag to disable default launch plan generation #170

merged 6 commits into from
Sep 2, 2020

Conversation

EngHabu
Copy link
Collaborator

@EngHabu EngHabu commented Aug 28, 2020 •
edited
Loading

TL;DR

Adds a flag to control whether a default launchplan should be generated for the workflow at registration time. The default behavior is to do so.

E.g.

@workflow_class(disable_default_launch_plan=True)
def MyWorkflow():
   ...

my_lp = MyWorkflow.create_launch_plan(...)

#my_lp will be the only launchplan created for this workflow

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#462

kumare3
kumare3 previously approved these changes Aug 28, 2020
View reviewed changes
rubenbarragan
rubenbarragan previously approved these changes Aug 28, 2020
View reviewed changes
@EngHabu EngHabu dismissed stale reviews from rubenbarragan and kumare3 via 5c75f30 September 1, 2020 21:41
@EngHabu
Copy link
Collaborator Author

EngHabu commented Sep 2, 2020

PTAL @wild-endeavor

rubenbarragan
rubenbarragan reviewed Sep 2, 2020
View reviewed changes
flytekit/__init__.py
@@ -2,4 +2,4 @@

import flytekit.plugins # noqa: F401

__version__ = "0.12.4"
__version__ = "0.12.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit question, do we have to change the version every change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@EngHabu EngHabu merged commit 3640b8b into master Sep 2, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
@EngHabu
Add a flag to disable default launch plan generation (flyteorg#170)
c0b845a 
* Add a flag to disable default launch plan generation

* Bump version

* lint

* typo

* lint
@honnix
Copy link
Member

honnix commented Nov 22, 2022 •
edited
Loading

Looks like this feature is gone. Is there a replacement? Thanks.

We do pyflyte package so it seems there is no flag to turn it off https://github.com/flyteorg/flytekit/blob/master/flytekit/tools/serialize_helpers.py#L75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenbarragan rubenbarragan rubenbarragan approved these changes

@matthewphsmith matthewphsmith Awaiting requested review from matthewphsmith

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EngHabu @honnix @rubenbarragan @kumare3