Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] FlyteKit- Allow users to avoid generating default launchplans #462

Closed
1 of 13 tasks
EngHabu opened this issue Aug 7, 2020 · 1 comment
Closed
1 of 13 tasks

[Feature] FlyteKit- Allow users to avoid generating default launchplans #462

EngHabu opened this issue Aug 7, 2020 · 1 comment
Assignees
@EngHabu
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.7.0

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Aug 7, 2020

Motivation: Why do you think this is important?
Launchplans allow authors to choose how users ultimately invoke a workflow. This includes requiring certain inputs to be filled or forcing certain values to certain inputs. There might be cases where the default launchplans that FlyteKit automatically generates are undesirable to be exposed.

Goal: What should the final outcome look like, ideally?
@workflow_class(disable_default_launch_plan=True) would not generate the default launchplan.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 7, 2020
@EngHabu EngHabu added this to the 0.7.0 milestone Aug 7, 2020
@EngHabu EngHabu self-assigned this Aug 7, 2020
@EngHabu
Copy link
Contributor Author

EngHabu commented Aug 7, 2020

CC @thechopkins

@EngHabu EngHabu mentioned this issue Aug 28, 2020
Merged
8 tasks
@kumare3 kumare3 modified the milestones: 0.7.0, 0.8.0 Sep 2, 2020
@EngHabu EngHabu closed this as completed Sep 2, 2020
@EngHabu EngHabu modified the milestones: 0.8.0, 0.7.0 Sep 2, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@hamersaw
Support external deletion of non-terminal map task subtasks (flyteorg…
e08953c 
…#462)

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pingsutw
Bump flyteidl version (flyteorg#462)
26601ee 
* Bump flyteidl version

Signed-off-by: Kevin Su <[email protected]>

* Bump flyteidl version

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* make ReadHeaderTimeout configurable

Signed-off-by: Kevin Su <[email protected]>

* update_boilerplate

Signed-off-by: Kevin Su <[email protected]>

* Address comment

Signed-off-by: Kevin Su <[email protected]>

* Address comment

Signed-off-by: Kevin Su <[email protected]>

* fix test

Signed-off-by: Kevin Su <[email protected]>

* update run-tests

Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
fix registry name in release (flyteorg#462)
ebe92e8 
Signed-off-by: Yuvraj <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
ci: resolve docker build issues (flyteorg#462)
c2ee154 
* ci: resolve docker build issues
* chore: remove unneeded changes

Signed-off-by: Nastya Rusina <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Support external deletion of non-terminal map task subtasks (flyteorg…
c2a41d3 
…#462)

* updated flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins version

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pingsutw
Bump flyteidl version (flyteorg#462)
5b047a1 
* Bump flyteidl version

Signed-off-by: Kevin Su <[email protected]>

* Bump flyteidl version

Signed-off-by: Kevin Su <[email protected]>

* lint

Signed-off-by: Kevin Su <[email protected]>

* make ReadHeaderTimeout configurable

Signed-off-by: Kevin Su <[email protected]>

* update_boilerplate

Signed-off-by: Kevin Su <[email protected]>

* Address comment

Signed-off-by: Kevin Su <[email protected]>

* Address comment

Signed-off-by: Kevin Su <[email protected]>

* fix test

Signed-off-by: Kevin Su <[email protected]>

* update run-tests

Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@EngHabu @kumare3