bug; Queuing budget no longer exists. Quality of service is not yet integrated #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This fix removes access of queuing_budget in flytekit as this is not used and there has been refactoring that renders the current Interface incorrect. Problems,
queuing_budget renamed to queueing_budget
field 1 in WorkflowMetadata is now QualityOfService instead
queueing budget is part of the QOSSpec and is one of.
Usage for the users was still access to queueing budget
Problems:
Flytekit was still accessing workflowmetadata.queuing_budget and this breaks in production for anyone who upgrades to latest flytekit.
Type
Bug Fix
Feature
Plugin
Are all requirements met?
Code completed
Smoke tested
Unit tests added
Code documentation added
Any pending items have an associated Issue
Complete description
Currently eliminated queuing_budget as it is not used. It should be re-introduced carefully thinking about the interface
Tracking Issue
flyteorg/flyte#410
Follow-up issue
NA