Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] flytekit 0.10.1 is broken, queuing_budget not found #410

Closed
2 of 13 tasks
kumare3 opened this issue Jul 12, 2020 · 1 comment
Closed
2 of 13 tasks

[BUG] flytekit 0.10.1 is broken, queuing_budget not found #410

kumare3 opened this issue Jul 12, 2020 · 1 comment
Assignees
@kumare3
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Milestone
0.6.0

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jul 12, 2020

Describe the bug
If you use latest version of flytekit (or flyteidl + flytekit)
Workflow execution launching fails

[2020-07-11 07:39:23,149] {base_task_runner.py:95} INFO - Subtask:   File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/flytekit/models/core/workflow.py", line 510, in from_flyte_idl
[2020-07-11 07:39:23,149] {base_task_runner.py:95} INFO - Subtask:     queuing_budget=pb2_object.queuing_budget.ToTimedelta() if pb2_object.queuing_budget else None,
[2020-07-11 07:39:23,149] {base_task_runner.py:95} INFO - Subtask: flytekit.common.exceptions.scopes.FlyteScopedSystemException: queuing_budget

Expected behavior
It should work

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

Additional context
This can be tested by registering and trying to launch an execution
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 12, 2020
@kumare3 kumare3 mentioned this issue Jul 12, 2020
Merged
8 tasks
@kumare3
Copy link
Contributor Author

kumare3 commented Jul 12, 2020

Also deleted 0.17.36 from PyPi

@kumare3 kumare3 self-assigned this Jul 12, 2020
@kumare3 kumare3 mentioned this issue Jul 12, 2020
Merged
@kumare3 kumare3 closed this as completed Jul 12, 2020
@kumare3 kumare3 added this to the 0.6.0 milestone Jul 12, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@MorpheusXAUT
Add interruptible override to workflow execution config #minor (flyte…
6591fa2 
…org#410)

* Fixed minor log message formatting

Signed-off-by: Nick Müller <[email protected]>

* Added override for interruptible flag to execution config

Signed-off-by: Nick Müller <[email protected]>

* Interruptible override now uses BoolValue wrapper
Allows for distinguishment between no value being provided and an override to false

Signed-off-by: Nick Müller <[email protected]>

* Test comments cleanup

Signed-off-by: Nick Müller <[email protected]>

* Use released flyteidl/flytepropeller versions

Signed-off-by: Nick Müller <[email protected]>
eapolinario added a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@eapolinario @samhita-alla
Feast integration (flyteorg#410)
40dc71f 
* Initial version

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add venv to dockerfile

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename feast integration dir

Signed-off-by: Eduardo Apolinario <[email protected]>

* Configure minio in the image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Refactoring + retrieve offline features

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove all_together

Signed-off-by: Eduardo Apolinario <[email protected]>

* Attempt to add s3 credentials to image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix s3 endpoint

Signed-off-by: Eduardo Apolinario <[email protected]>

* custom provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Transform FeatureView prior to executing queries

Signed-off-by: Eduardo Apolinario <[email protected]>

* Set PYTHONPATH

Signed-off-by: Eduardo Apolinario <[email protected]>

* Set PYTHONPATH to multiple values

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove "custom_provider" from path

Signed-off-by: Eduardo Apolinario <[email protected]>

* Replace minio endpoint

Signed-off-by: Eduardo Apolinario <[email protected]>

* Print env vars

Signed-off-by: Eduardo Apolinario <[email protected]>

* Set FEAST_S3_ENDPOINT_URL while building feature store

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove minio credentials from image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add aws env vars

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove mention to local provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove piping of registry object

Signed-off-by: Eduardo Apolinario <[email protected]>

* Create random path via FlyteContext

Signed-off-by: Eduardo Apolinario <[email protected]>

* Revert "Remove piping of registry object"

This reverts commit ccdf3264bb5b428eb2b474d8422a21a5bb82b0b5.

Signed-off-by: Eduardo Apolinario <[email protected]>

* Clean up feature description and remove debugging statements

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add tasks up to `train_model`

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment use of custom provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* fix error in training

Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>

* Add TODO

Signed-off-by: Eduardo Apolinario <[email protected]>

* Import feature_eng tasks directly

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add store_online task

Signed-off-by: Eduardo Apolinario <[email protected]>

* Copy remote file to a local file and replace batch_source in materialize

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add some debugging statements and fix local execution parameter

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add remaining steps to workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Regenerate requirements files

Signed-off-by: Eduardo Apolinario <[email protected]>

* Regenerate requirements and put replacement of remote files back in custom provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add more logging

Signed-off-by: Eduardo Apolinario <[email protected]>

* Regenerate requirements again

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add workflow return type

Signed-off-by: Eduardo Apolinario <[email protected]>

* Include a directory prefix in the model filename

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove unused overrides in custom provider and comment use of localize_feature_view

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add type transformer

Signed-off-by: Eduardo Apolinario <[email protected]>

* Pipe _Feature_Store to all interactions with feast

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove unnecessary override in custom provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rearrange initialization of FeatureStore for better legibility

Signed-off-by: Eduardo Apolinario <[email protected]>

* Revert "Remove unnecessary override in custom provider"

This reverts commit 2808ba07b2ba73f77d2f6c1a08aba0c2cdccea97.

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use create_node to enforce order

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove unused function

Signed-off-by: Eduardo Apolinario <[email protected]>

* Guard env vars behind a check

Signed-off-by: Eduardo Apolinario <[email protected]>

* Expose inputs to workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Task to build FeatureStore

Signed-off-by: Eduardo Apolinario <[email protected]>

* Do not guard env vars behind a check

Signed-off-by: Eduardo Apolinario <[email protected]>

* Experiment with converted_df

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comments

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove commented code from type transformer

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove unused portion of sandbox.config

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove TODO

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove registry parameter from local execution

Signed-off-by: Eduardo Apolinario <[email protected]>

* No need for type transformers

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove mentions to type transformers

Signed-off-by: Eduardo Apolinario <[email protected]>

* Copy README.rst from flyteorg/flytesnacks#322

Signed-off-by: Eduardo Apolinario <[email protected]>

* Step 3 of guide on adding a new integration

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove extraneous print statement and turn comments into docstrings in custom provider

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comments on README.rst

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix link to feast

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix serialization of feast_integration dir

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@MorpheusXAUT
Add interruptible override to workflow execution config #minor (flyte…
ed6056c 
…org#410)

* Fixed minor log message formatting

Signed-off-by: Nick Müller <[email protected]>

* Added override for interruptible flag to execution config

Signed-off-by: Nick Müller <[email protected]>

* Interruptible override now uses BoolValue wrapper
Allows for distinguishment between no value being provided and an override to false

Signed-off-by: Nick Müller <[email protected]>

* Test comments cleanup

Signed-off-by: Nick Müller <[email protected]>

* Use released flyteidl/flytepropeller versions

Signed-off-by: Nick Müller <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@pingsutw
Rename externalPluginService to AgentService (#410)
1e785cc 
* Rename externalPluginService to AgentService

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@pingsutw @eapolinario
Rename externalPluginService to AgentService (#410)
12fd98d 
* Rename externalPluginService to AgentService

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@pingsutw
Rename externalPluginService to AgentService (#410)
5749b26 
* Rename externalPluginService to AgentService

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@GRomR1
Include default MinIO credentials (flyteorg#410)
8428367 
flyteorg#3458 Include default MinIO credentials in sandbox console readout

Signed-off-by: Ruslan Gainanov <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@GRomR1
Include default MinIO credentials (flyteorg#410)
2322858 
flyteorg#3458 Include default MinIO credentials in sandbox console readout

Signed-off-by: Ruslan Gainanov <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@GRomR1 @austin362667
Include default MinIO credentials (flyteorg#410)
cb88789 
flyteorg#3458 Include default MinIO credentials in sandbox console readout

Signed-off-by: Ruslan Gainanov <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@GRomR1 @robert-ulbrich-mercedes-benz
Include default MinIO credentials (flyteorg#410)
243b967 
flyteorg#3458 Include default MinIO credentials in sandbox console readout

Signed-off-by: Ruslan Gainanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumare3 kumare3

Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@kumare3