-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Added doc on how to handle a large response when using FlyteRemote.sync #1212
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
@samhita-alla Hey I mentioned about the large response just like you asked. Check from Line 302 Do you want any changes? :) |
* Open HashMethod to all types * Fix test in test_type_hints.py Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: LN <[email protected]>
Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: LN <[email protected]>
…ies (flyteorg#1192) The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PROTOBUF-3031740 Signed-off-by: LN <[email protected]>
* pyflyte run non-fast register Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: LN <[email protected]>
Added about large response while using Remote.Sync() and how to handle it in the doc Signed-off-by: LN <[email protected]>
@Ln11211, I see multiple files that have already been merged into the master branch. Please ensure only the file of concern is present by rebasing the branch. |
I don't understand what happened, I synced my fork and then used the |
Here is what I think I'm supposed to do-- |
Hopefully! If that doesn't work, please create a new PR. |
@samhita-alla Good news, All I had to do was update my fork and pull all new commits and that fixed the problem, I feel relieved that the problem got solved easily... |
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 68.57% 68.57%
=======================================
Files 288 288
Lines 26225 26225
Branches 2929 2929
=======================================
Hits 17985 17985
Misses 7762 7762
Partials 478 478 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
updating FlyteRemote sync message Co-authored-by: Samhita Alla <[email protected]>
Updated the fix for the error and also removed the repeated error message line. Signed-off-by: LN <[email protected]>
Congrats on merging your first pull request! 🎉 |
@Ln11211, seems like the content's not rendering properly. Would you mind creating a flytekit PR to remove the |
Yup. I'll do it right now |
Here it is #1229 @samhita-alla |
TL;DR
Updated
control_plane.rst
docType
Are all requirements met?
Complete description
Added about large response while using Remote.Sync and how to handle it in the
control_plane.rst
doc. This PR is in reference to flyteorg/flyte#2932 (comment) and issue #2809.Tracking Issue
flyteorg/flyte#2809
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/