fix bug (#1216)

Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Oct 3, 2022 · 0bd3261 · 0bd3261
1 parent 63ad4fc
commit 0bd3261
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/flytekit/core/container_task.py b/flytekit/core/container_task.py
@@ -81,7 +81,8 @@ def execute(self, **kwargs) -> Any:
         return None
 
     def get_container(self, settings: SerializationSettings) -> _task_model.Container:
-        env = {**settings.env, **self.environment} if self.environment else settings.env
+        env = settings.env or {}
+        env = {**env, **self.environment} if self.environment else env
         return _get_container_definition(
             image=self._image,
             command=self._cmd,

diff --git a/tests/flytekit/unit/core/test_serialization.py b/tests/flytekit/unit/core/test_serialization.py
@@ -32,6 +32,7 @@ def test_serialization():
         inputs=kwtypes(val=int),
         outputs=kwtypes(out=int),
         image="alpine",
+        environment={"a": "b"},
         command=["sh", "-c", "echo $(( {{.Inputs.val}} * {{.Inputs.val}} )) | tee /var/outputs/out"],
     )