Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite SQLite3 Task image #1165

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Overwrite SQLite3 Task image #1165

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82582a9
Overwrite SQLite3Task image
pingsutw Sep 15, 2022
24d88f2
fix lint error
pingsutw Sep 15, 2022
9096267
remove comment
pingsutw Sep 16, 2022
9f09f5c
nit
pingsutw Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions flytekit/extras/sqlite3/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import pandas as pd

from flytekit import FlyteContext, kwtypes
from flytekit.configuration import SerializationSettings
from flytekit.configuration import DefaultImages, SerializationSettings
from flytekit.core.base_sql_task import SQLTask
from flytekit.core.python_customized_container_task import PythonCustomizedContainerTask
from flytekit.core.shim_task import ShimTaskExecutor
Expand Down Expand Up @@ -79,6 +79,7 @@ def __init__(
inputs: typing.Optional[typing.Dict[str, typing.Type]] = None,
task_config: typing.Optional[SQLite3Config] = None,
output_schema_type: typing.Optional[typing.Type[FlyteSchema]] = None,
container_image: typing.Optional[str] = None,
**kwargs,
):
if task_config is None or task_config.uri is None:
Expand All @@ -88,7 +89,7 @@ def __init__(
name=name,
task_config=task_config,
# If you make changes to this task itself, you'll have to bump this image to what the release _will_ be.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the comment?

container_image="ghcr.io/flyteorg/flytekit:v0.19.0",
container_image=container_image or DefaultImages.default_image(),
executor_type=SQLite3TaskExecutor,
task_type=self._SQLITE_TASK_TYPE,
query_template=query_template,
Expand Down
8 changes: 7 additions & 1 deletion tests/flytekit/unit/extras/sqlite3/test_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import pandas

from flytekit import kwtypes, task, workflow
from flytekit.configuration import DefaultImages
from flytekit.extras.sqlite3.task import SQLite3Config, SQLite3Task

# https://www.sqlitetutorial.net/sqlite-sample-database/
Expand Down Expand Up @@ -99,4 +100,9 @@ def test_task_serialization():
]

assert tt.custom["query_template"] == "select TrackId, Name from tracks limit {{.inputs.limit}}"
assert tt.container.image != ""
assert tt.container.image == DefaultImages.default_image()

image = "xyz.io/docker2:latest"
sql_task._container_image = image
tt = sql_task.serialize_to_model(sql_task.SERIALIZE_SETTINGS)
assert tt.container.image == image