Overwrite SQLite3 Task image #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 68.51% 68.53% +0.02%
==========================================
Files 288 288
Lines 26085 26197 +112
Branches 2918 2924 +6
==========================================
+ Hits 17871 17954 +83
- Misses 7735 7765 +30
+ Partials 479 478 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kevin Su <[email protected]>
samhita-alla
previously approved these changes
Sep 15, 2022
eapolinario
reviewed
Sep 16, 2022
flytekit/extras/sqlite3/task.py
Outdated
| @@ -88,7 +89,7 @@ def __init__( | |||
| name=name, | |||
| task_config=task_config, | |||
| # If you make changes to this task itself, you'll have to bump this image to what the release _will_ be. | |||
There was a problem hiding this comment.
Can you remove the comment?
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
previously approved these changes
Sep 16, 2022
Signed-off-by: Kevin Su <[email protected]>
eapolinario
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su [email protected]
TL;DR
Users should be able to overwrite the SQL task's image.
If they don't specify the image in the SQL task, then use the default image instead.
Type
Are all requirements met?
Complete description
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR