Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Remove accelerator_value oneof in core.ResourceMetadata #442

Closed
wants to merge 2 commits into from

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Sep 21, 2023

Addresses: #419 (comment)

@welcome
Copy link

welcome bot commented Sep 21, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@jeevb jeevb mentioned this pull request Sep 21, 2023
8 tasks
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.55% 🎉

Comparison is base (ef37788) 75.92% compared to head (ce14edd) 78.48%.

❗ Current head ce14edd differs from pull request most recent head 18af7aa. Consider uploading reports for the commit 18af7aa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jeev B <[email protected]>
@jeevb jeevb closed this Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants