add comment

Signed-off-by: Jeev B <[email protected]>
flyteorg · Sep 21, 2023 · 18af7aa · 18af7aa
1 parent 8b5724d
commit 18af7aa
Show file tree

Hide file tree

Showing 11 changed files with 170 additions and 5 deletions.
diff --git a/gen/pb-go/flyteidl/core/tasks.pb.go b/gen/pb-go/flyteidl/core/tasks.pb.go
diff --git a/gen/pb-go/flyteidl/service/admin.swagger.json b/gen/pb-go/flyteidl/service/admin.swagger.json
diff --git a/gen/pb-go/flyteidl/service/agent.swagger.json b/gen/pb-go/flyteidl/service/agent.swagger.json
diff --git a/gen/pb-go/flyteidl/service/external_plugin_service.swagger.json b/gen/pb-go/flyteidl/service/external_plugin_service.swagger.json
diff --git a/gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml b/gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
diff --git a/gen/pb-go/flyteidl/service/flyteadmin/model_core_resource_metadata.go b/gen/pb-go/flyteidl/service/flyteadmin/model_core_resource_metadata.go
diff --git a/gen/pb-go/flyteidl/service/openapi.go b/gen/pb-go/flyteidl/service/openapi.go
diff --git a/gen/pb-java/flyteidl/core/Tasks.java b/gen/pb-java/flyteidl/core/Tasks.java
diff --git a/gen/pb_python/flyteidl/service/flyteadmin/flyteadmin/models/core_resource_metadata.py b/gen/pb_python/flyteidl/service/flyteadmin/flyteadmin/models/core_resource_metadata.py
diff --git a/gen/pb_rust/flyteidl.core.rs b/gen/pb_rust/flyteidl.core.rs
diff --git a/protos/flyteidl/core/tasks.proto b/protos/flyteidl/core/tasks.proto
@@ -72,6 +72,12 @@ message GPUAccelerator {
 
 // Additional metadata associated with resources to allocate to a task
 message ResourceMetadata {
+    // Selection of GPU accelerators currently involves using node selectors and/or
+    // tolerations to schedule a given workload on the right node group. Given that
+    // these are attributes of the pod, and not directly associated with the primary
+    // container's resource specification (the `nvidia.com/gpu` resource name is used
+    // across accelerators), we pass this request through as resource metadata
+    // instead.
     GPUAccelerator gpu_accelerator = 1;
 }