This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Dockerize buf call #356
Merged
Dockerize buf call #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 18 18
Lines 1362 1362
=======================================
Hits 996 996
Misses 315 315
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pingsutw
approved these changes
Jan 5, 2023
wild-endeavor
approved these changes
Jan 5, 2023
eapolinario
added a commit
that referenced
this pull request
Feb 22, 2023
This reverts commit 398c54f. Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Dockerizing the
bufcall so users do not need to manually installbufto generate protos. The PR uses the existing approach of setting the user id but requires manually setting the buf cache directory. If not set it will default to the root users home (ie./.cache) which the caller likely does not have permissions to access. Therefore, we set it to/tmp/cachewhich should be globally accessible.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3139
Follow-up issue
NA