Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Migrate protobuf stub generation to buf #3139

Open
2 tasks done
eapolinario opened this issue Dec 7, 2022 · 2 comments
Open
2 tasks done

[Housekeeping] Migrate protobuf stub generation to buf #3139

eapolinario opened this issue Dec 7, 2022 · 2 comments
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@eapolinario
Copy link
Contributor

Describe the issue

We currently rely on a series of old (and very-hard-to-update) code to generate the stubs for the different languages we support in flyteidl.

Instead we should leverage buf and move over the step at which we generate the stubs, e.g. if we adopt buf remote plugins we don't even have to maintain generated stubs.

What if we do not do this?

It's nearly impossible to update the original script, this makes it hard for us to adopt newer technologies, for example grpc-gateway v2 (which includes the swagger/openapiv2 annotations).

Related component(s)

flyteidl

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 5, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

1 participant