This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Move proto from datacatalog #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: niant <[email protected]>
tnsetting
force-pushed
the
move_catalog_proto
branch
from
af6a404 to
eeed0fd
Compare
Signed-off-by: niant <[email protected]>
tnsetting
force-pushed
the
move_catalog_proto
branch
from
eb8becd to
f74aefe
Compare
kumare3
reviewed
Mar 11, 2021
|
|
||
| message Parameter { | ||
| service DataCatalog { |
There was a problem hiding this comment.
awesome, thank you. Maybe we should have a follow up to document better here
There was a problem hiding this comment.
Yes. The document for datacatalog is very little.
kumare3
approved these changes
Mar 11, 2021
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Move proto from datacatalog Signed-off-by: niant <[email protected]> * add generated files Signed-off-by: niant <[email protected]> Co-authored-by: niant <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#827
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/