This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
[housekeeping] Use proto gen file from flyteidl #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: niant <[email protected]>
tnsetting
changed the title
kumare3
approved these changes
Mar 12, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: niant <[email protected]> Co-authored-by: niant <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use the gen code from flyteidl and remove the proto as the datacatalog proto has been moved to flyteidl already.
Type
Are all requirements met?
Complete description
Currently the proto/idl for datacatalog lives in this repo but it makes more sense to move to the flyteidl repo since all flyte idls are defined there. So proto have been moved already in PR: flyteorg/flyteidl#113 and this PR is to use the gen code from flyteidl and remove the proto.
Tracking Issue
flyteorg/flyte#827
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/