Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Add the missing exports for demo #330

Merged
merged 1 commit into from
Jun 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/sandbox/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func StartDemoCluster(ctx context.Context, args []string, sandboxConfig *sandbox
if err != nil {
return err
}
util.PrintDemoMessage(util.DemoConsolePort)
util.PrintSandboxMessage(util.DemoConsolePort)
return nil
}

Expand Down
6 changes: 0 additions & 6 deletions pkg/util/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@ func PrintSandboxMessage(flyteConsolePort int) {
fmt.Printf("export FLYTECTL_CONFIG=%v \n", configutil.FlytectlConfig)
}

// PrintDemoMessage will print demo success message
func PrintDemoMessage(flyteConsolePort int) {
successMsg := fmt.Sprintf("%v http://localhost:%v/console", ProgressSuccessMessage, flyteConsolePort)
fmt.Printf("%v %v %v %v %v \n", emoji.ManTechnologist, successMsg, emoji.Rocket, emoji.Rocket, emoji.PartyPopper)
}

// SendRequest will create request and return the response
func SendRequest(method, url string, option io.Reader) (*http.Response, error) {
client := &http.Client{}
Expand Down
6 changes: 0 additions & 6 deletions pkg/util/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ func TestPrintSandboxMessage(t *testing.T) {
})
}

func TestPrintDemoMessage(t *testing.T) {
t.Run("Print Demo Message", func(t *testing.T) {
PrintDemoMessage(DemoConsolePort)
})
}

func TestSendRequest(t *testing.T) {
t.Run("Successful get request", func(t *testing.T) {
response, err := SendRequest("GET", "https://github.com", nil)
Expand Down