Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Add the missing exports for demo #330

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Add the missing exports for demo #330

merged 1 commit into from
Jun 15, 2022

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar [email protected]

Read then delete

  • Make sure to use a concise title for the pull-request.
  • Use #patch, #minor #majora or #none in the pull-request title to bump the corresponding version. Otherwise, the patch version
    will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Prafulla Mahindrakar <[email protected]>
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #330 (76d7f10) into master (e92f7fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   69.51%   69.49%   -0.02%     
==========================================
  Files         139      139              
  Lines        4829     4826       -3     
==========================================
- Hits         3357     3354       -3     
  Misses       1230     1230              
  Partials      242      242              
Flag Coverage Δ
unittests 69.07% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/util.go 85.36% <ø> (-1.00%) ⬇️
pkg/sandbox/start.go 78.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92f7fc...76d7f10. Read the comment docs.

@pmahindrakar-oss pmahindrakar-oss merged commit 0cbf036 into master Jun 15, 2022
@pmahindrakar-oss pmahindrakar-oss deleted the fix-message branch June 15, 2022 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants