Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dont push docker images for PRs #95

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Sep 2, 2020

flyteorg/flyte#495

We don't need images for every PR and it breaks checks on forks. So I'm removing the pushing from the PR checks and just doing a simple build to verify that the Dockerfile isn't broken.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files         371      371           
  Lines        5992     5992           
  Branches      932      932           
=======================================
  Hits         4045     4045           
  Misses       1947     1947           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e209b0...e5b1f3d. Read the comment docs.

@schottra schottra requested a review from EngHabu September 2, 2020 23:02
@schottra schottra merged commit 1448569 into master Sep 2, 2020
@schottra schottra deleted the remove-pr-image-pushes branch September 9, 2020 19:42
@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants