Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions for flyteconsole do not work on forks #495

Closed
schottra opened this issue Sep 2, 2020 · 0 comments
Closed

Github actions for flyteconsole do not work on forks #495

schottra opened this issue Sep 2, 2020 · 0 comments
Assignees
@schottra
Labels
bug Something isn't working ui Admin console user interface
Milestone
0.8.0

Comments

@schottra
Copy link
Contributor

schottra commented Sep 2, 2020

We have two github actions which build/push Docker images to Github and Dockerhub. These were only designed to work on primary repository. They will fail on PRs from forks and give false negatives on PR checks.

We should update the actions to not attempt a push when on a fork.
@schottra schottra added the bug Something isn't working label Sep 2, 2020
@schottra schottra added this to the 0.8.0 milestone Sep 2, 2020
@schottra schottra self-assigned this Sep 2, 2020
@schottra schottra added the ui Admin console user interface label Sep 2, 2020
@schottra schottra mentioned this issue Sep 2, 2020
Merged
@schottra schottra closed this as completed Sep 2, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@pingsutw @hamersaw
Persist flyte deck during workflow recovery (flyteorg#495)
4d8f800 
Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@hamersaw
Adding CheckAndFetchInputsForExecution on single task executions (fly…
905e7ee 
…teorg#495)

* adding CheckAndFetchInputsForExecution on single task executions

Signed-off-by: Dan Rammer <[email protected]>

* fixed unit test

Signed-off-by: Dan Rammer <[email protected]>

* fixed typo

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
fix: separate api auth to plugin folder (flyteorg#495)
7ea0c9f 
* fix: separate api auth to plugin folder
* chore: for local admin URL is undefined
* chore: update README.md
* test: fix tests + add new ones
* v0.0.2 - release for flyte-api plugin

Signed-off-by: Nastya <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@pingsutw @hamersaw
Persist flyte deck during workflow recovery (flyteorg#495)
fbe6f23 
Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Adding CheckAndFetchInputsForExecution on single task executions (fly…
b8f409b 
…teorg#495)

* adding CheckAndFetchInputsForExecution on single task executions

Signed-off-by: Dan Rammer <[email protected]>

* fixed unit test

Signed-off-by: Dan Rammer <[email protected]>

* fixed typo

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
bug Something isn't working ui Admin console user interface
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@schottra