Get full inputs/outputs from execution data #92
Conversation
|
cc @kumare3 |
|
@kanterov today you showed that you know typescript 😜. But why not a separate PR |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 66.70% 67.49% +0.79%
==========================================
Files 370 371 +1
Lines 5962 6009 +47
Branches 930 938 +8
==========================================
+ Hits 3977 4056 +79
+ Misses 1985 1953 -32
Continue to review full report at Codecov.
|
|
@kanterov Thanks for doing this! The other PR should be merged today and you can rebase off of master after that. Or you could just update the version of flyteidl in package.json and run Would you mind writing/updating tests for the components that you changed to make sure they use the new data when it's available and fall back to the old data otherwise? |
kanterov
force-pushed
the
use-full-inputs-outputs
branch
from
b22923f to
f3012ca
Compare
|
@schottra done. Some non-code related builds checks are failing, it seems I need to configure something for them to work. Do I need to fix those? |
|
@kanterov I think the build/push actions are expected to fail, since they run from a fork and you won't have permissions to push to github/dockerhub. I should update those to not run on forked repositories. |
|
@kanterov If you rebase on latest master, I've updated the Github actions, so two of those failed checks should now pass. |
|
@schottra sorry it took some time, but now everything is done :) please take a look again |
# [0.12.0](http://github.com/lyft/flyteconsole/compare/v0.11.0...v0.12.0) (2020-09-22) ### Features * get full inputs/outputs from execution data ([#92](http://github.com/lyft/flyteconsole/issues/92)) ([78b250d](http://github.com/lyft/flyteconsole/commit/78b250d665cbd5aa95bae995da40d364ef96a509))
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Fixes Input/Output view when using GCS.
Type
Are all requirements met?
Complete description
flyteadmin doesn't know how to return public URLs for GCS objects. It returns URL in format
gs://...that doesn't work. This fixes Input/Output view when using GCS for Storage by using new fullInputs/fullOutputs fields in getExecutionData proto. Change is backward-compatible, if full inputs/outputs aren't present, it's going to fallback on the existing mechanism.I had to take 6a3b80f and few other commits because I needed new fields in flyteidl.
Tracking Issue
flyteorg/flyte#444
Follow-up issue
NA