feat: get full inputs/outputs from execution data

flyteorg · Aug 31, 2020 · b22923f · b22923f
1 parent 2c4a879
commit b22923f
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 20 deletions.
diff --git a/src/components/Executions/ExecutionDetails/ExecutionNodeDetails/OutputNodeDetails.tsx b/src/components/Executions/ExecutionDetails/ExecutionNodeDetails/OutputNodeDetails.tsx
@@ -13,10 +13,16 @@ const RemoteExecutionOutputs: React.FC<{ execution: Execution }> = ({
 }) => {
     const executionData = useWorkflowExecutionData(execution.id);
     return (
-        <WaitForData {...executionData}>
-            {() => (
-                <RemoteLiteralMapViewer blob={executionData.value.outputs} />
-            )}
+        <WaitForData {...executionData} spinnerVariant="none">
+            {() => {
+                executionData.value.fullOutputs !== undefined ? (
+                    <LiteralMapViewer map={executionData.value.fullOutputs} />
+                ) : (
+                    <RemoteLiteralMapViewer
+                        blob={executionData.value.outputs}
+                    />
+                );
+            }}
         </WaitForData>
     );
 };

diff --git a/src/components/Executions/ExecutionDetails/NodeExecutionData.tsx b/src/components/Executions/ExecutionDetails/NodeExecutionData.tsx
@@ -3,7 +3,7 @@ import Typography from '@material-ui/core/Typography';
 import { WaitForData } from 'components/common';
 import { useCommonStyles } from 'components/common/styles';
 import { useNodeExecutionData } from 'components/hooks';
-import { RemoteLiteralMapViewer } from 'components/Literals';
+import { LiteralMapViewer, RemoteLiteralMapViewer } from 'components/Literals';
 import { NodeExecution } from 'models';
 import * as React from 'react';
 
@@ -26,9 +26,16 @@ export const NodeExecutionData: React.FC<{ execution: NodeExecution }> = ({
                                 </Typography>
                             </header>
                             <section>
-                                <RemoteLiteralMapViewer
-                                    blob={executionData.value.inputs}
-                                />
+                                {executionData.value.fullInputs !==
+                                undefined ? (
+                                    <LiteralMapViewer
+                                        map={executionData.value.fullInputs}
+                                    />
+                                ) : (
+                                    <RemoteLiteralMapViewer
+                                        blob={executionData.value.inputs}
+                                    />
+                                )}
                             </section>
                         </div>
                     </div>

diff --git a/src/components/Executions/ExecutionDetails/NodeExecutionInputs.tsx b/src/components/Executions/ExecutionDetails/NodeExecutionInputs.tsx
@@ -1,7 +1,7 @@
 import { WaitForData } from 'components/common';
 import { useCommonStyles } from 'components/common/styles';
 import { useNodeExecutionData } from 'components/hooks';
-import { RemoteLiteralMapViewer } from 'components/Literals';
+import { LiteralMapViewer, RemoteLiteralMapViewer } from 'components/Literals';
 import { NodeExecution } from 'models';
 import * as React from 'react';
 
@@ -17,9 +17,15 @@ export const NodeExecutionInputs: React.FC<{ execution: NodeExecution }> = ({
                 <>
                     <div className={commonStyles.detailsPanelCard}>
                         <div className={commonStyles.detailsPanelCardContent}>
-                            <RemoteLiteralMapViewer
-                                blob={executionData.value.inputs}
-                            />
+                            {executionData.value.fullInputs !== undefined ? (
+                                <LiteralMapViewer
+                                    map={executionData.value.fullInputs}
+                                />
+                            ) : (
+                                <RemoteLiteralMapViewer
+                                    blob={executionData.value.inputs}
+                                />
+                            )}
                         </div>
                     </div>
                 </>

diff --git a/src/components/Executions/ExecutionDetails/NodeExecutionOutputs.tsx b/src/components/Executions/ExecutionDetails/NodeExecutionOutputs.tsx
@@ -1,7 +1,7 @@
 import { WaitForData } from 'components/common';
 import { useCommonStyles } from 'components/common/styles';
 import { useNodeExecutionData } from 'components/hooks';
-import { RemoteLiteralMapViewer } from 'components/Literals';
+import { LiteralMapViewer, RemoteLiteralMapViewer } from 'components/Literals';
 import { NodeExecution } from 'models';
 import * as React from 'react';
 
@@ -17,9 +17,15 @@ export const NodeExecutionOutputs: React.FC<{ execution: NodeExecution }> = ({
                 <>
                     <div className={commonStyles.detailsPanelCard}>
                         <div className={commonStyles.detailsPanelCardContent}>
-                            <RemoteLiteralMapViewer
-                                blob={executionData.value.outputs}
-                            />
+                            {executionData.value.fullOutputs !== undefined ? (
+                                <LiteralMapViewer
+                                    map={executionData.value.fullOutputs}
+                                />
+                            ) : (
+                                <RemoteLiteralMapViewer
+                                    blob={executionData.value.outputs}
+                                />
+                            )}
                         </div>
                     </div>
                 </>

diff --git a/src/components/Executions/ExecutionInputsOutputsModal.tsx b/src/components/Executions/ExecutionInputsOutputsModal.tsx
@@ -42,7 +42,13 @@ const RemoteExecutionInputs: React.FC<{ execution: Execution }> = ({
     const executionData = useWorkflowExecutionData(execution.id);
     return (
         <WaitForData {...executionData} spinnerVariant="none">
-            {() => <RemoteLiteralMapViewer blob={executionData.value.inputs} />}
+            {() => {
+                executionData.value.fullInputs !== undefined ? (
+                    <LiteralMapViewer map={executionData.value.fullInputs} />
+                ) : (
+                    <RemoteLiteralMapViewer blob={executionData.value.inputs} />
+                );
+            }}
         </WaitForData>
     );
 };
@@ -53,9 +59,15 @@ const RemoteExecutionOutputs: React.FC<{ execution: Execution }> = ({
     const executionData = useWorkflowExecutionData(execution.id);
     return (
         <WaitForData {...executionData} spinnerVariant="none">
-            {() => (
-                <RemoteLiteralMapViewer blob={executionData.value.outputs} />
-            )}
+            {() => {
+                executionData.value.fullOutputs !== undefined ? (
+                    <LiteralMapViewer map={executionData.value.fullOutputs} />
+                ) : (
+                    <RemoteLiteralMapViewer
+                        blob={executionData.value.outputs}
+                    />
+                );
+            }}
         </WaitForData>
     );
 };

diff --git a/src/models/Execution/types.ts b/src/models/Execution/types.ts
@@ -124,4 +124,6 @@ export interface TaskExecutionClosure extends Admin.ITaskExecutionClosure {
 export interface ExecutionData {
     inputs: UrlBlob;
     outputs: UrlBlob;
+    fullInputs?: LiteralMap;
+    fullOutputs?: LiteralMap;
 }